Update glm5-fp4-b200-sglang-mtp SGLang image to v0.5.11-cu130#1328
Update glm5-fp4-b200-sglang-mtp SGLang image to v0.5.11-cu130#1328Klaud-Cold wants to merge 1 commit into
Conversation
…1154\n\nCo-authored-by: Klaud Cold <Klaud-Cold@users.noreply.github.com>
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers. If additional help is needed, PR authors can reach out to core maintainers over Slack. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| - glm5-fp4-b200-sglang-mtp | ||
| description: | ||
| - "Update SGLang image from v0.5.10.post1-cu130 to v0.5.11-cu130" | ||
| pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXX |
There was a problem hiding this comment.
🟡 The new perf-changelog entry for glm5-fp4-b200-sglang-mtp has pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXX — the placeholder was not replaced before opening the PR. Since this is PR #1328, the link should be pull/1328 to match the format used by every other entry in this file.
Extended reasoning...
The diff at perf-changelog.yaml line 2351 adds a new changelog entry whose pr-link field is https://github.com/SemiAnalysisAI/InferenceX/pull/XXX. The XXX is clearly a literal placeholder string that was never substituted with the actual PR number.
Every other entry in perf-changelog.yaml references a concrete PR number — the four entries immediately above this one use 1304, 1305, 1308, and 1310 respectively. A link with XXX resolves to a non-existent GitHub URL and breaks the changelog's navigability.
Step-by-step proof:
- The PR metadata states this is PR Update glm5-fp4-b200-sglang-mtp SGLang image to v0.5.11-cu130 #1328.
- The new entry at
perf-changelog.yaml:2351adds:pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXX. - Visiting
https://github.com/SemiAnalysisAI/InferenceX/pull/XXXdoes not resolve to a real PR (the path segment must be an integer). - The neighboring entries at lines 2325, 2332, 2338, and 2345 follow the convention
pull/<integer>(1304, 1305, 1308, 1310). - Therefore the correct value here is
pull/1328.
Impact: This is a documentation/metadata issue only — it doesn't affect runtime behavior. However, the changelog is a key navigation aid for tracing perf regressions back to the PR that introduced them, so a broken link defeats the file's purpose for this entry.
Fix: Replace pull/XXX with pull/1328 on line 2351.
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=25763420008 |
1 participant
Summary
glm5-fp4-b200-sglang-mtpimage fromlmsysorg/sglang:v0.5.10.post1-cu130tolmsysorg/sglang:v0.5.11-cu130Ref #1154
Generated with Claude Code